Add traefik airgap image tarball #6439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandond
force-pushed
the
add-traefik-airgap
branch
from
c2b79d6 to
339a547
Compare
ShylajaDevadiga
approved these changes
Jul 31, 2024
Note that we are not providing a core image without ingress-nginx; anyone who wants to use traefik instead of ingress-nginx will need to load the core tarball (with the ingress-nginx images) in addition to the traefik tarball. We will continue to ship ingress-nginx in the core tarball until it is no longer the default. Signed-off-by: Brad Davidson <[email protected]>
brandond
force-pushed
the
add-traefik-airgap
branch
from
339a547 to
83dbba6
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6439 +/- ##
=======================================
Coverage 25.23% 25.23%
=======================================
Files 33 33
Lines 2829 2829
=======================================
Hits 714 714
Misses 2068 2068
Partials 47 47
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
dereknola
approved these changes
Jul 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Add traefik airgap image tarball
Note that we are not providing a core image without ingress-nginx; anyone who wants to use traefik instead of ingress-nginx will need to load the core tarball (with the ingress-nginx images) in addition to the traefik tarball. We will continue to ship ingress-nginx in the core tarball until it is no longer the default.
Types of Changes
airgap
Verification
See linked issue
Testing
Linked Issues
rke2-traefikImage is missing from airgap tarball #6438User-Facing Change
Further Comments